exasol / python-toolbox

Infrastructure & Automation Tooling for Python Projects
https://exasol.github.io/python-toolbox/
MIT License
2 stars 0 forks source link

✨ Check and fix marking the version file as "generated" in file .gitattributes #192

Closed ckunki closed 3 months ago

ckunki commented 3 months ago

Summary

This ticket requests to mark the version file as "generated" in file .gitattributes.

Details

This could be implemented in method fix() In file exasol/toolbox/nox/_format.py.

Result could be like

version.py   linguist-generated

Background & Context

Reviewers can ignore generated files and focus on manual changes, making reviews easier, reducing effort for reviews and focusing on important changes.

Examples

See https://github.com/exasol/project-keeper/blob/main/.gitattributes

References

See https://github.com/exasol/project-keeper/

Task(s)

Nicoretti commented 3 months ago

Hi @ckunki,

Great idea, but by now the need for having a version file is obsolete for our use cases, see also importlib.metadata. So in the long run, we rather need to get rid of the version files. Therefore, I don't think it makes sense to add an automated fix for this issue.

Still very good idea, keep em coming ;)

best Nico