Closed Shmuma closed 3 months ago
I am not sure the unit test is needed, as it practically replicates this test in the python-extension-common
We should also change the documentation since we have new parameters in the cli. Plus the usual changelog.
I am not sure the unit test is needed, as it practically replicates this test in the python-extension-common
Yes, I used it for the inspiration, but unit test I added is working on a different level - we're checking the functionality of the subclass of the class provided by python-extension-common. As they are now live in separate repos/packages, superclass might change the behaviour without updating the subclass. The test is basic, but I think it is better than nothing
We should also change the documentation since we have new parameters in the cli. Plus the usual changelog.
Hm, what new parameter do you mean? I added no new parameters.
Good point about the changelog, will add.
The new parameters are related to SaaS.
Created a separate task to update the documentation: https://github.com/exasol/sagemaker-extension/issues/122
Closes #118