exasol / sql-statement-builder

Build SQL statements safely without string concatenation
MIT License
25 stars 4 forks source link

Refactor `BooleanExpressionVisitor` #100

Closed jakobbraun closed 3 years ago

jakobbraun commented 4 years ago

Currently, BooleanExpressionVisitor uses visit and leave. I've got the feeling that it would be better style to only use visit in combination with recursive calls, but I'm not sure about that.

jakobbraun commented 4 years ago

By that we could also rewrite the current logic:

connect(and);
this.connectorDeque.push(" AND ");

to something more readable like Sering.joing("AND", ...)