search

exasol / sql-statement-builder

Build SQL statements safely without string concatenation
MIT License
25 stars 4 forks source link

Refactor ValueTableVisitor #125

Closed kaklakariada closed 4 months ago

kaklakariada commented 3 years ago

Refactor the ValueTableVisitor interface like ColumnsDefinitionRenderer (#102) or BooleanExpressionVisitor (#100).

redcatbear commented 1 year ago

I gave this one a shot and realized that, while with the previous refactorings the classes got smaller, we lost runtime efficiency and diluted the design (e.g. where SoC is broken now). So it looks like the whole visitor structure will need a clean redesign. Preferably done in pair programming mode.

kaklakariada commented 4 months ago

We don't have the capacity to implement this at the moment.