search

exasol / transformers-extension

An Exasol extension for using state-of-the-art pretrained machine learning models via the Hugging Face Transformers API.
MIT License
2 stars 2 forks source link

Change the code downloading the SLC #134

Closed ahsimb closed 10 months ago

ahsimb commented 11 months ago

The failure mode is the language container deployment using Quick Installation.

Currently the assumption is that the SLC is stored in parts. This is no longer true - it's just one file. In the current release (0.5.0) it's exasol_transformers_extension_container_release.tar.gz.

The changes should be made starting from the function deployment.deployment_utils.get_container_file_from_github_release(version)

### Tasks
- [x] affected: deployment_utils SLC_PARTS_PREFIX_NAME, _concatenate_slc_parts, _download_slc_parts
- [x] check for naming differences of the slc-files throughout the project
- [x] also the GH_RELEASE_URL is not correct (i checked it is correct)
MarleneKress79789 commented 11 months ago

The name of the language container to download changed with the versions. should we continue to let the user select which version language container they want, risking the code version they have attempting to download a non existent file? or check for the possible name options which one exists for the selected version? or set the version automatically depending on the installed version of the package? or just mention in the docu to take care and install same version slc as package?