search

exasol / transformers-extension

An Exasol extension for using state-of-the-art pretrained machine learning models via the Hugging Face Transformers API.
MIT License
2 stars 2 forks source link

Make the ALTER SYSTEM call for the SLC definition toggleable #151

Closed tkilias closed 9 months ago

tkilias commented 9 months ago

Currently the SLC definition always executes the command ALTER SYSTEM.

The current ticket requests to enable users to select if the command ALTER SYSTEM should be executed:

  1. For the CLI, the default behavior is upload + run ALTER SYSTEM. The user can provide command line parameters to disable upload and/or run ALTER SYSTEM. When run ALTER SYSTEM is disabled, we print the ALTER SYSTEM/SESSION command to the CLI.
  2. The API should be split into functions, upload, create_slc_definition, create_alter_system, run_alter_system and one function which combines them

Comment regarding run ALTER SYSTEM: the current implementation reads the slc definitions from the DB and adds the new one. However, it is implemented, such that it prevents overwriting an existing ALIASES.

ahsimb commented 9 months ago

Actually, the current implementation allows overwriting the alias with a new definition, it just logs a warning if this alias already exists.