Moretables review proposals

exasol / virtual-schema-common-jdbc

Common module for JDBC-based access from Virtual Schemas

MIT License

0 stars 1 forks source link

Closed ckunki closed 1 year ago

ckunki commented 1 year ago

Fixes #133

ckunki commented 1 year ago

I love this! Thanks for investing so much time to refactor the validation and making an actual class for the parameter including its behavior!

Thanks - this is a motivating reward for me.

However, now that you have opened the can of worms... should not most of the new code be put into virtual-schema-java? :)

Maybe. I am not sure, yet. But I would leave that as a separate ticket / PR, if you are OK with that.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!