exasol / virtual-schemas

Entry point repository for the EXASOL Virtual Schemas
http://www.exasol.com
MIT License
24 stars 23 forks source link

#354: Adapter notes must be strings #385

Closed redcatbear closed 4 years ago

redcatbear commented 4 years ago

Closes #354.

redcatbear commented 4 years ago

@exanm, applied your findings. Please check again.

I only found one instance of "information" though where a plural article was used. The other instances had no article.

exanm commented 4 years ago

@redcatbear, please change the four adapterNotes examples in the file to strings. I would just use the quoting approach here.

redcatbear commented 4 years ago

I turned the examples into a simple key-value encoding. This stresses the fact that adapter notes are only strings and is easier to read and write.

redcatbear commented 4 years ago

@exanm, please check again.

sonarcloud[bot] commented 4 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information