search

exbin / bined-netbeans-plugin

Hex viewer/editor plugin for NetBeans platform
https://bined.exbin.org/netbeans-plugin
Apache License 2.0
5 stars 1 forks source link

Couple of problems with bined-netbeans-plugin #15

Closed Chris2011 closed 8 months ago

Chris2011 commented 2 years ago

Unfortunately the discussion section is not acitve so I created this ticket instead. There are some problems for people of using your plugin. I will just add the links to the created issues and hope that you can see the problem somehow fast. If you need more info, I can try to add tickets for every problem and try to check them before doing this:

https://github.com/apache/netbeans/issues/3797 - md opened as binary https://github.com/apache/netbeans/issues/4584 - A java.lang.NoClassDefFoundError exception has occurred https://github.com/apache/netbeans/issues/4657 - Variables window show no variables

hajdam commented 2 years ago

Hi, thanks for reporting. I noticed ClassNotFoundException issue (second and third link) few weeks ago. It's nbm building issue - not passing optional dependency after gradle nbm extension was updated. Reverted to mandatory dependency in current bined plugin development build. https://bined.exbin.org/download/?org-exbin-bined-netbeans.nbm

Plan was to probably rework building to maven, but I didn't get to it yet.

As to first issue, I blame substandard NetBeans design/architecture ;-) - after killing thousands of plugins, I don't expect they would care to improve that, so I'll try to take a look if I can find any mitigation to this issue...

Chris2011 commented 2 years ago

Hey thx for the info. I think problem one we already had this. But I dunno why your plugin seems the only one to create such a problem? Maybe this: https://github.com/exbin/bined-netbeans-plugin/issues/3

hajdam commented 2 years ago

Created new build today trying to fix the issue with md files context menu (issue with internal "-nb" filetype postfix). It seems uninstalling event is not called by NetBeans, not sure I can do anything about that... Also optional module dependencies still doesn't seem to work for me :-/ https://bined.exbin.org/download/?org-exbin-bined-netbeans.nbm

I'll try to release plugin in next few days... Nobody reported the issue, so nobody uses the plugin anyway, therefore there is probably no reason to rush...

hajdam commented 2 years ago

Released version 0.2.4. It doesn't seem I can request verification in Plugin Portal thou...

Chris2011 commented 2 years ago

Why do you think that the problem has smth todo with the postfix of the mimetype? Shouldn't that be a problem? I mean the devil is in details sometimes but what will the problem be here? Will check your new version soon.

hajdam commented 2 years ago

It's my best guess and it seems to fix the issue with md files context menu for me. I didn't find any relevant documentation or section in NetBeans source code, so I guess that postfix is the case for dynamically registered mimetypes. I already spend too many hours on this, so as always, this is my best effort result...

Chris2011 commented 2 years ago

I think it was a mistake by them. If you have a look inside the MarkdownDataObject there is also text/x-markdown and texst/x-markdown-nb so I think -nb should be removed but I dunno why Jan did this.

hajdam commented 2 years ago

Not sure where you see that, I don't see it here: https://github.com/madflow/flow-netbeans-markdown/blob/nb8/src/flow/netbeans/markdown/MarkdownDataObject.java Maybe I'm looking on the wrong plugin, but it any case, I'm ok with the "-nb" hack being present in the current version / for few months - don't want to publish updates too often, so that I would be required to create router plugin according to Plugin Portal rules ;-)

Chris2011 commented 2 years ago

Markdown was natively implemented into NetBeans. Just the syntax highlighting. There is no need of any other plugin: https://github.com/apache/netbeans/blob/master/ide/markdown/src/org/netbeans/modules/markdown/MarkdownDataObject.java#L108 and here is the other line: https://github.com/apache/netbeans/blob/master/ide/markdown/src/org/netbeans/modules/markdown/MarkdownDataObject.java#L123 I don't use flow netbeans anymore. So maybe this should be fixed first from text/x-markdown-nb to text/x-markdown. There is no need for -nb The other plugin that I use is this: https://github.com/moacirrf/netbeans-markdown because of the split view.

hajdam commented 2 years ago

Requested verification of version 0.2.4. I assumed I had to wait before requesting it as the buttons were not available, but I had to drop previous verification first :-|

Chris2011 commented 2 years ago

Unfortunately I don't know how the verification works. Will check your plugin soon and will add a comment into the initial issues.

Chris2011 commented 2 years ago

Can you please also add your new version to your github repo? Current version is still 0.2.2.

Chris2011 commented 2 years ago

Did you forget to add the nbm file to the releases section or don't you want to? The intention was to have the nbm file also here until there is the verification.

hajdam commented 2 years ago

I didn't use github release for nbms for this project. You can download nbm on project's website, on NetBeans plugins site or in maven repository.

hajdam commented 8 months ago

Forgot to close this. Assuming it's fixed in both 0.2.4 and 0.2.5.