excalibur1234 / pacui

Bash script providing advanced Pacman and Yay/Pikaur/Aurman/Pakku/Trizen/Pacaur/Pamac-cli functionality in a simple UI
GNU General Public License v3.0
169 stars 13 forks source link

imprecise result in 'search package files' option #17

Closed excalibur1234 closed 6 years ago

excalibur1234 commented 7 years ago

in the devel branch, i have just rewritten the "search package files" option of pacui.

the code is not more complicated and i use more files (a.k.a. the code is more ugly). but i managed to get rid of a long awk command. this resulted in a dramatic performance increase. for example, you want to search for files ending with "config" and search for "config$". on my system, pacui 1.6 needs longer than 2 min to display the result (15135 lines). the rewritten code needs less than 10 sec to display the result (15219 lines).

pros:

cons

in my opinion, showing duplicate results (in some cases) is acceptable when i get such a performance increase as return. what do you think?

excalibur1234 commented 7 years ago

this change is now in the master branch and can be installed by (re)installing pacui-git from AUR.

i have done more performance tests: when searching for "con", roughly 130k lines of results are displayed. the new imprecise results take less than 10s to be displayed while the old precise method takes longer than 15min to display the result.

excalibur1234 commented 6 years ago

nobody has complained about possible duplicate search results until now.

i am closing this issue. feel free to reopen it anytime.