excaliburjs / Excalibur

🎮 Your friendly TypeScript 2D game engine for the web 🗡️
https://excaliburjs.com
BSD 2-Clause "Simplified" License
1.82k stars 188 forks source link

Excalibur sandbox test compilation fails locally #1010

Closed jedeen closed 3 years ago

jedeen commented 6 years ago

Currently, the build and test scripts do not appropriately clear out files from previous runs for the sandbox tests. We need to update our build automation to account for this.

Steps to Reproduce

npm run all

Expected Result

Successful build of Excalibur and run of the test suite

Actual Result

Compilation fails for the sandbox tests

Current Workaround

Delete the compiled files in the /sandbox folder

alanag13 commented 6 years ago

I experienced this problem too, but once I deleted the compiled files it didn't happen anymore. I think we must have changed something about the way the visual tests compile/where the scripts come from because new builds do not create compiled files in the /sandbox folder, but we can still successfully run the sandbox after they are removed. Best I can tell, anyone cloning the repo fresh shouldn't have this problem.

eonarheim commented 6 years ago

We should add a clean step to nuke old compiled files, this is a poor developer experience when pulling latest master and a total head scratcher for me for 30 minutes

github-actions[bot] commented 3 years ago

This issue hasn't had any recent activity lately and is being marked as stale automatically.

eonarheim commented 3 years ago

I don't believe this is an issue anymore