excaliburjs / Excalibur

🎮 Your friendly TypeScript 2D game engine for the web 🗡️
https://excaliburjs.com
BSD 2-Clause "Simplified" License
1.83k stars 191 forks source link

Lowercase all files/folders in excalibur #1175

Open eonarheim opened 5 years ago

eonarheim commented 5 years ago

Steps to Reproduce

Issue is detailed here #1123, default semantics for imports.

Specific comment https://github.com/excaliburjs/Excalibur/issues/1123#issuecomment-483004520

Importing a barrel is clumsy because of the capitalization. This will cause breaking changes in folks using capitalized import paths. Also this tricky to change on windows because of it's case insensitivity in the file system.

Expected Result

Importing files should follow the best practice and standards in JS/TS.

Index.ts should be index.ts which is the conventional way for module resolves to be handled. It can alternative partially fixed by doing import {PointerEvent} from 'excalibur/dist/Input/Index' but then you get compiler errors saying that Document isn't a property of undefined on PointerScope for whatever reason.

Actual Result

Index must be explicitly stated in the import

Environment

Current Workaround

Import the barrel directly like this import {PointerEvent} from 'excalibur/dist/Input/Index'

github-actions[bot] commented 3 years ago

This issue hasn't had any recent activity lately and is being marked as stale automatically.

github-actions[bot] commented 1 month ago

This issue hasn't had any recent activity lately and is being marked as stale automatically.