search

excaliburjs / Excalibur

🎮 Your friendly TypeScript 2D game engine for the web 🗡️
https://excaliburjs.com
BSD 2-Clause "Simplified" License
1.76k stars 188 forks source link

Correct the BoundingBox.intersect(other: BoundingBox): Vector comments positions #3010

Open ikudrickiy opened 5 months ago

ikudrickiy commented 5 months ago

Context

All 4 multiline comments are placed incorrectly

Screenshot ![image](https://github.com/excaliburjs/Excalibur/assets/139219793/bc4626d5-2302-4ad6-bd06-a6aeb317830d)

Proposal

Correct the comments positions

ikudrickiy commented 5 months ago

Ah, seems like it is just another comment positioning principle. Do we have a rule to follow in this question? Should we? Shouldn't we?

ikudrickiy commented 5 months ago

Pay attention to this

3011

first

eonarheim commented 5 months ago

@ikudrickiy Fair point! Yah these comments are confusingly placed... this could be improved.

We'll chat about #3011 first as you say!

github-actions[bot] commented 3 months ago

This issue hasn't had any recent activity lately and is being marked as stale automatically.