excaliburjs / Excalibur

🎮 Your friendly TypeScript 2D game engine for the web 🗡️
https://excaliburjs.com
BSD 2-Clause "Simplified" License
1.81k stars 188 forks source link

Bad background color in _DEFAULT_ENGINE_OPTIONS #3110

Open spustlik opened 4 months ago

spustlik commented 4 months ago

line 705:

    backgroundColor: Color.fromHex('#2185d0') // Excalibur blue

should be

    backgroundColor: Color.ExcaliburBlue

Environment

Autsider666 commented 4 months ago

Correct me if I'm wrong, but I'm 93% sure it's not the intention of @spustlik to call the usage of Color.fromHex bad, but point out the difference between the used hex color in the engine (#2185d0, from here on out EngineBlue) vs the hex color used in Color.ExcaliburBlue (#176BAA, from here on out ExcaliburBlue).

These seem to be used interchangeably all throughout the codebase, so some time should probably be taken to pick the "official" EX hex color to consistently use everywhere.

EngineBlue

ExcaliburBlue

eonarheim commented 4 months ago

@Autsider666 Many thanks for digging into this, I'll dig through and sort this out and make it consistent.

Who knows what past Erik was thinking here :/

Autsider666 commented 3 months ago

I've some free time to fix this. I'd just need to know what the "real" ExcaliburBlue color is out of these 2.

github-actions[bot] commented 1 month ago

This issue hasn't had any recent activity lately and is being marked as stale automatically.