excaliburjs / Excalibur

🎮 Your friendly TypeScript 2D game engine for the web 🗡️
https://excaliburjs.com
BSD 2-Clause "Simplified" License
1.81k stars 188 forks source link

Fix odd method name ex.Util.removeItemToArray to ex.Util.removeItemFromArray #798

Closed eonarheim closed 7 years ago

eonarheim commented 7 years ago

Context

This is an oddly worded confusing method ex.Util.removeItemToArray, it just needs to be renamed.

Proposal

Rename it to ex.Util.removeItemFromArray

Crizzooo commented 7 years ago

Can I take this as a first PR? does seem very easy though hahaha

eonarheim commented 7 years ago

Go for it! :)

On Tue, May 2, 2017, 20:05 Christopher Rizzo notifications@github.com wrote:

Can I take this as a first PR? does seem very easy though hahaha

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/excaliburjs/Excalibur/issues/798#issuecomment-298801975, or mute the thread https://github.com/notifications/unsubscribe-auth/AAlW52Hbe-tsOxvoGyDUY9XYUTJtJ-rDks5r19LTgaJpZM4NMUHT .

Crizzooo commented 7 years ago

Changed the method and added test specs. I think I followed most rules I found in the Contributing guidelines as far as writing tests, referencing changes/issues, making the PR - how'd I do?

I didn't do much, but that was fun. Got any other beginner issues to get my feet wet with?

kamranayub commented 7 years ago

Anything tagged jump-in is up for grabs! Plenty of work to be done!

On Mon, May 22, 2017, 11:39 Christopher Rizzo notifications@github.com wrote:

Changed the method and added test specs. I think I followed most rules I found in the Contributing guidelines as far as writing tests, referencing changes/issues, making the PR - how'd I do?

I didn't do much, but that was fun. Got any other beginner issues to get my feet wet with?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/excaliburjs/Excalibur/issues/798#issuecomment-303154020, or mute the thread https://github.com/notifications/unsubscribe-auth/AAiaa3hua_n3rts6HMz2EolAhexyWyVYks5r8bovgaJpZM4NMUHT .

Crizzooo commented 7 years ago

@kamranayub Cool, I'm currently eyeing #612 and getting familiar with TypeScript now. This one seems pretty easy, just making this.pos = new Vector(x, y), but I'm waiting for some feedback before going forward.

Crizzooo commented 7 years ago

@kamranayub or @eonarheim - this issue can be closed and was handled in #812

kamranayub commented 7 years ago

@Crizzooo Actually that PR was closed because the commits were lost. I'd make a new branch and re-submit.

htalat commented 7 years ago

Can i submit a PR for this if its still open?

jedeen commented 7 years ago

Closed in 0.11.0