search

excalidraw / excalidraw-vscode

Excalidraw for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=pomdtr.excalidraw-editor
MIT License
477 stars 60 forks source link

Allow the user to set excalidraw theme to `light` or `dark` #22

Closed pomdtr closed 2 years ago

pomdtr commented 2 years ago

The main issue to handle is a setting change while the document was in the background.

ad1992 commented 2 years ago

@pomdtr its already present in the package, the host can use theme prop to set it.

pomdtr commented 2 years ago

@ad1992 yes, the issue is not related to the excalidraw package, it is specific to the extension.

Currently the user is able to control the theme from the extension using the excalidraw.syncTheme setting. However, I would like to provide an excalidraw.theme option instead, providing a dropdown with auto, dark or light options.

mderazon commented 2 years ago

@pomdtr any ETA on when this will be merged ? It's a great addition. My VSC theme is dark, but I don't like Excalidraw dark mode and prefer the white one so it's nice to be able to override that.

mderazon commented 2 years ago

Sorry, my bad, I changed excalidraw.syncTheme but didn't realize that I had to close the document and reopen. Now it's all good.

Thanks for this really useful extension!

pomdtr commented 2 years ago

This will be fixed in the next version of the extension (you can test it using the pre-release version).

Thanks for the nice words !