Improve theme preference discoverability and behaviour

excalidraw / excalidraw-vscode

Excalidraw for Visual Studio Code

https://marketplace.visualstudio.com/items?itemName=pomdtr.excalidraw-editor

MIT License

477 stars 60 forks source link

Improve theme preference discoverability and behaviour #37

Closed pomdtr closed 2 years ago

pomdtr commented 2 years ago

Fix #34

default to light theme
update webview on config change
add a command to update the theme
add a button to switch theme in the editor menu

https://user-images.githubusercontent.com/17577332/164325072-83be61cc-f2cd-4acf-9412-d15b3914cd4d.mp4

dwelle commented 2 years ago

Looks good!

Can we remove https://github.com/excalidraw/excalidraw-vscode/pull/37/files#diff-0e96fc4c0e4b663545725cc50af120099cb873ea9e3f16eee74d074e39be13feR53-R59 ?

pomdtr commented 2 years ago

Looks good!

Can we remove https://github.com/excalidraw/excalidraw-vscode/pull/37/files#diff-0e96fc4c0e4b663545725cc50af120099cb873ea9e3f16eee74d074e39be13feR53-R59 ?

Not sure of what you are talking about, the github redirection is not very explicit.

dwelle commented 2 years ago

Sorry, It thought it was a permalink: https://github.com/excalidraw/excalidraw-vscode/blob/c357605e73dbc020cc1c4742a6229373582c9505/extension/package.json#L53-L59