excalidraw / excalidraw-vscode

Excalidraw for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=pomdtr.excalidraw-editor
MIT License
477 stars 60 forks source link

excalidraw preview not displayed in gitpod/openvscode-server (no exceptions logged in browser console nor in the container log) #56

Open talsenteam opened 2 years ago

talsenteam commented 2 years ago

Does this issue occur when all extensions are disabled?: Yes

Steps to Reproduce:

  1. Clone this repository: https://github.com/talsenteam/issue-gitpod-openvscode-server-excalidraw-preview-not-displayed
  2. Run docker compose up --detach
  3. Visit http://localhost:3000/?folder=/home/workspace in your browser (preferrably Chromium without Extensions)
  4. Navigate to the extensions store and install the Excalidraw plugin pomdtr.excalidraw-editor
  5. Open the readonly file test.excalidraw in the editor

More info & some screenshots can be found in the linked repository.

Expected Behavior

The excalidraw preview / editor should be usable when working on http://localhost:3000 without even a reverse proxy (that may cause issues due to some CORS, etc settings).

Workaround

As mentioned by @pomdtr : The Excalidraw extension can be installed via the vsix file ( https://marketplace.visualstudio.com/items?itemName=pomdtr.excalidraw-editor ), then it works.

Notes

Linked Issue: https://github.com/gitpod-io/openvscode-server/issues/393

What do we need to do in order to get the extension to be displayed in the browser? many thanks in advance !!

pomdtr commented 2 years ago

Thanks for reporting this. The issue is caused by a bug in openvsx (see https://github.com/eclipse/openvsx/issues/468)

pomdtr commented 2 years ago

Installing the extension from the vsix file might fix the error.

talsenteam commented 2 years ago

Installing the extension from the vsix file might fix the error.

Thanks for the hint! Installing it via the vsix file ( https://marketplace.visualstudio.com/items?itemName=pomdtr.excalidraw-editor ) works!

talsenteam commented 2 years ago

Should we leave this issue open here?, because it is marked as upstream pointing to the openvsx repo, and may (probably) take a while until it gets resolved over there.

pomdtr commented 2 years ago

I think it's ok, it will allow other users to find the workaround

pomdtr commented 2 years ago

You can also add the release url to your workspace gitpod.yml

vscode:
  extensions:
    - https://github.com/excalidraw/excalidraw-vscode/releases/download/v3.2.0/excalidraw-editor-3.2.0.vsix