excalidraw / excalidraw

Virtual whiteboard for sketching hand-drawn like diagrams
https://excalidraw.com
MIT License
76.9k stars 7.03k forks source link

don't persist collab scenes to localStorage #2826

Open dwelle opened 3 years ago

dwelle commented 3 years ago

As a measure to decrease the likelihood that users think they still collaborate on a scene when they open a new tab (or a new tab is opened for them) during collaboration, I'd not persist scene data to localStorage during collaboration so that opening a new tab won't result in the same scene being duplicated (loaded) from localStorage.

During collaboration, we save the data to a server, anyway.

downsides

dwelle commented 3 years ago

This also open a question: should we "leak" scene data from collaboration scenes at all?

Case: someone (be it a company or a person) sends you a confidential diagram to collaborate on. You then stop the session (or close the tab etc.). The state when you left the room is kept both in 1) active scene, and 2) localStorage.

This isn't a problem on its own, but may result in expected behavior. For example, you close the tab when collaborating and leave the workstation. Someone then opens a clean excalidraw.com tab and lo and behold, it has the data from your last collaboration.