search

excalidraw / excalidraw

Virtual whiteboard for sketching hand-drawn like diagrams
https://excalidraw.com
MIT License
84.51k stars 7.97k forks source link

Enable selection of single elements to unlock when locked for better UX #5141

Open ad1992 opened 2 years ago

ad1992 commented 2 years ago

As per UX, I feel it's not intuitive to disable selection and I am not sure why we are disabling selection, even when you right-click the element it gets selected. As per the flow, I select an element -> right-click, -> lock, hence I am expecting then when I click on an element again it will select it, and then I can either use the context menu/shortcut to unlock it. Miro, Figjam , whimisical allow the selection of lock elements and show a visual indicator to unlock as well which makes it more intuitive. Hence I would suggest we allow selection and show some indicator (eg lock icon) that makes it clear that the element is locked so the user needs to unlock it(clicking on lock icon will unlock the element).

And this is most helpful during collaboration where users don't know which elements are locked and which aren't And one more thing, disabling selection+ not showing indicator might look like a bug when someone tries to interact with the elements (eg move, resize) unless the user is aware of the lock functionality in Excalidraw

In case we want to disable selection then I suggest showing some indicator that makes it more clear how to unlock and why the selection is disabled but to align with other tools I think we should allow selection + some indicator to unlock when selected as well.

bradwood commented 2 years ago

I have exactly this problem, I selected a ton of items with a drag, locked them all, and now I realised I locked too many things and I want to bulk select them to unlock them. How do I do that?

adrianbienias commented 2 years ago

I have exactly this problem, I selected a ton of items with a drag, locked them all, and now I realised I locked too many things and I want to bulk select them to unlock them. How do I do that?

Same here. Missing such feature looks like a bug. There should be something like an "unlock all" option.

pikatwinky commented 2 years ago

I have a similar problem in mobile, i am learning how to use this tool and I locked several items. It seems to me its not possible to revert that situation in a phone/tablet

zaidakhterr commented 1 year ago

Having the same issue here!

dwelle commented 1 year ago

we could merge https://github.com/excalidraw/excalidraw/pull/5894/files to help unlock all elements on scene

zaidakhterr commented 1 year ago

This looks good, what are the steps needed to merge this? I haven't contributed to this repo yet, but anyway that I can help?

CromyNews commented 6 months ago

I have exactly this problem, I selected a ton of items with a drag, locked them all, and now I realised I locked too many things and I want to bulk select them to unlock them. How do I do that?

I'm struggling with unlocking multiple objects. Although it's not a fundamental solution, here's my current approach. When I want to lock multiple objects, it's more convenient to first group them and then apply the lock.

Mungoid commented 3 months ago

I think my main issue with the locking is that if i have some layered objects (some text, shape, etc inside of a box), the largest object (the box) seems to always get the context when i right click, even over text. So I have to unlock the larger object, move it, unlock the stuff inside, then move the box back.

Ultimately not a huge issue, but definitely does break the flow of quickly sketching out a diagram. I think in my case an easy way to just unlock everything would be very helpful.