excalidraw / excalidraw

Virtual whiteboard for sketching hand-drawn like diagrams
https://excalidraw.com
MIT License
76.63k stars 6.99k forks source link

[Feature request] Create Nginx healthcheck endpoint #7404

Open modem7 opened 6 months ago

modem7 commented 6 months ago

Currently the healthcheck spams the logs with:

2023-12-06T18:58:51.890954995Z 127.0.0.1 - - [06/Dec/2023:18:58:51 +0000] "GET / HTTP/1.1" 200 3751 "-" "Wget" "-"
2023-12-06T18:59:21.955635473Z 127.0.0.1 - - [06/Dec/2023:18:59:21 +0000] "GET / HTTP/1.1" 200 3751 "-" "Wget" "-"
2023-12-06T18:59:52.023524788Z 127.0.0.1 - - [06/Dec/2023:18:59:52 +0000] "GET / HTTP/1.1" 200 3751 "-" "Wget" "-"
2023-12-06T19:00:22.063441005Z 127.0.0.1 - - [06/Dec/2023:19:00:22 +0000] "GET / HTTP/1.1" 200 3751 "-" "Wget" "-"
2023-12-06T19:00:52.118770703Z 127.0.0.1 - - [06/Dec/2023:19:00:52 +0000] "GET / HTTP/1.1" 200 3751 "-" "Wget" "-"
2023-12-06T19:01:22.158012575Z 127.0.0.1 - - [06/Dec/2023:19:01:22 +0000] "GET / HTTP/1.1" 200 3751 "-" "Wget" "-"
2023-12-06T19:01:52.222436579Z 127.0.0.1 - - [06/Dec/2023:19:01:52 +0000] "GET / HTTP/1.1" 200 3751 "-" "Wget" "-"
2023-12-06T19:02:22.307293230Z 127.0.0.1 - - [06/Dec/2023:19:02:22 +0000] "GET / HTTP/1.1" 200 3751 "-" "Wget" "-"
2023-12-06T19:02:52.367296673Z 127.0.0.1 - - [06/Dec/2023:19:02:52 +0000] "GET / HTTP/1.1" 200 3751 "-" "Wget" "-"
2023-12-06T19:03:22.418738068Z 127.0.0.1 - - [06/Dec/2023:19:03:22 +0000] "GET / HTTP/1.1" 200 3751 "-" "Wget" "-"
2023-12-06T19:03:52.465878306Z 127.0.0.1 - - [06/Dec/2023:19:03:52 +0000] "GET / HTTP/1.1" 200 3751 "-" "Wget" "-"

A healthcheck endpoint in nginx would probably be more suitable.

E.g.

        location /healthz {
            return 200;
        }
dwelle commented 6 months ago

I'm missing the context here...

modem7 commented 6 months ago

Apologies.

Effectively, the healthcheck command is filling up the logs with ping commands when it (arguably) shouldn't (in this case, it's noise).

A health endpoint in nginx wouldn't suffer from this particular behaviour, and allow the console logs to be used for useful diagnosis