excalidraw / virgil

The old-font that powered Excalidraw. Now replaced by Excalifont.
https://plus.excalidraw.com/virgil
SIL Open Font License 1.1
624 stars 18 forks source link

feat: Ellinor's updates #46

Closed lipis closed 3 years ago

lipis commented 3 years ago

Fixes #13 Fixes #20 Fixes #21 Fixes #41 Fixes #34

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

๐Ÿ” Inspect: https://vercel.com/excalidraw/virgil/AMYvN2NGCxuaKhZTXVtzM6wEtxWX
โœ… Preview: https://virgil-git-ellinor-changes-excalidraw.vercel.app

thorn0 commented 3 years ago

23 doesn't seem to have been fixed:

image

thorn0 commented 3 years ago

13 hasn't been fully fixed. Only uppercase Cyrillic letters were updated. Lowercase "ะต", "ัƒ", "ั…" are still worse than their Latin homographs.

thorn0 commented 3 years ago
Before: ![image](https://user-images.githubusercontent.com/94334/111082566-9d9a3780-8511-11eb-812d-960a37f093a5.png) After: ![image](https://user-images.githubusercontent.com/94334/111082580-b4d92500-8511-11eb-9e6b-5289ac9fdfb5.png)

It's subjective, of course, but the old version looks better to me, more expressive. As far as I know, there were no complaints about these letters. But if the goal is to make the font more neutral, then this change is okay.

lipis commented 3 years ago

It's subjective, of course, but the old version looks better to me, more expressive. As far as I know, there were no complaints about these letters. But if the goal is to make the font more neutral, then this change is okay.

I like the new version...

lipis commented 3 years ago

23 doesn't seem to have been fixed:

image

Removed it from the desc

lipis commented 3 years ago

13 hasn't been fully fixed. Only uppercase Cyrillic letters were updated. Lowercase "ะต", "ัƒ", "ั…" are still worse than their Latin homographs.

Yes, how should we go about these changes in the future.. shall we merge this and create a new one for these letters?

Maybe next time mentioning up to 2 letters per issue for easier tracking?

thorn0 commented 3 years ago

Yes, how should we go about these changes in the future.. shall we merge this and create a new one for these letters?

Yes, sounds good

Maybe next time mentioning up to 2 letters per issue for easier tracking?

:+1: