search

excalith / excalith-start-page

Terminal-inspired, clean, feature-rich and customizable browser start page for geeks. Has built-in editor for customizing.
https://excalith-start-page.vercel.app
MIT License
554 stars 163 forks source link

[BUG] Page Freezes upon returning #17

Closed ArmoredVortex closed 1 year ago

ArmoredVortex commented 1 year ago

Describe the bug

The startpage freezes when returning back using the "Go Back" button in the browser or Alt+Left shortcut. Search commands and shortcuts still work, but "help", "fetch" etc don't. Refreshing the page makes it work again. Console reports no error

To Reproduce

Steps to reproduce the behavior:

  1. Open startpage
  2. Search for something
  3. Return back using the "Go Back" button in browser
  4. Page freezes, no commands work

Expected behavior Not freeze upon returning

Screenshots

https://user-images.githubusercontent.com/66690593/228450978-4ca7696f-2650-4000-ab57-714d7604257b.mp4

Specs:

Additional context I encountered similar behavior on another startpage, issue is linked below https://github.com/kholmogorov27/chevron/issues/1

excalith commented 1 year ago

Hey @ArmoredVortex thank you so much for reporting this in a beautiful way! I will get working on it as soon as possible. Cheers!

excalith commented 1 year ago

Hello @ArmoredVortex, I have a temporary fix for this. It will require more finesse and will fix this properly with the upcoming features since they will requre better state handling. You can preview the branch from this link: http://start-page-git-fix-page-freeze-excalith.vercel.app?_vercel_share=m2KiPmAzAgV6S7BcIyUA2Sgx3zY85Jcv

Would love to hear the status on your end. I will also try it on arch soon.

ArmoredVortex commented 1 year ago

Oh wow, It works! No issues so far. I can finally get to daily driving the startpage now. Awesome startpage, Thanks! :heart:

excalith commented 1 year ago

I just tested on

and also works on my machine 😄

Thanks again for the heads up, sending a PR and releasing v2.1.1!