Search without Autocompletion

NitroSniper commented 8 months ago

Description of the Change

src/utils/command.js:

Refactored the 'normal' search into a function called DefaultSearch and exposed it.

src/components/Search.js:

imported DefaultSearch to the file.
Const isCtrlPressed to tell if CTRL or META is pressed (refactored from code found).
Ternary expression to choose search function and executes that function with parameters.
README.md
Added to keybinds the changes implemented.
fixed a typo I saw while editing.

Possible Drawbacks

Use of the ternary operator could be unreadable however I can read it perfectly and prevents duplicating 2 functions with the same parameters.
The keybind also ignores commands along with autocompletion however I think people will intend of ignoring it if used. e.g. searching "w hotels"

Further note:

I am loving the project and am using it as my home page for my workflow. amazing stuff here and keep up the good work!

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
start-page	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 25, 2023 4:01am

excalith commented 8 months ago

Hey @NitroSniper, thanks for the PR! Everything seems to be in order and working as intended.

The only drawback I could imagine was binding ignoring commands, but as you mentioned it won't be much of a hassle since it works as force search command.

Merging and will deploy soon with another request for window transparency feature.

Cheers!

PS: Thanks so much for your kind words, I am really glad that people enjoy using this project as their daily homepage!

excalith / excalith-start-page