search

excalith / excalith-start-page

Terminal-inspired, clean, feature-rich and customizable browser start page for geeks. Has built-in editor for customizing.
https://excalith-start-page.vercel.app
MIT License
568 stars 173 forks source link

[BUG] "+" character removed while searching #68

Closed NitroSniper closed 9 months ago

NitroSniper commented 9 months ago

Describe The Bug

When searching with the + character anywhere in the buffer. It will be removed when searching which can change the normal results. Even force search will have this issue.

To Reproduce

Steps to reproduce the behavior:

  1. Go to StartPage
  2. Search either:
    • "How to do string split in c++" => How to do string split in c
    • "(3 + 4) + (4 + 3)" => "(3 4) (4 3)"
  3. You'll see current search result being changed

Expected Behavior

For the search result to not be changed

Specs

excalith commented 9 months ago

Hey @NitroSniper!

Nice catch, I need to use encodeURIComponent to properly encode the string in order to work with requests.

The string should be encoded to ouput something like this in order for engines to properly handle symbols:

https://www.google.com/search?q=How%20to%20do%20string%20split%20in%20c%2B%2B

Will start working on it as soon as possible and release as a hotfix when it is ready.

Cheers!

excalith commented 9 months ago

Fixed with PR #69, releasing the hotfix as 3.1.2 now