[BUG] target doesn’t apply

excalith / excalith-start-page

Terminal-inspired, clean, feature-rich and customizable browser start page for geeks. Has built-in editor for customizing.

https://excalith-start-page.vercel.app

MIT License

554 stars 163 forks source link

[BUG] target doesn’t apply #71

Closed rohansharma-developer closed 5 months ago

rohansharma-developer commented 6 months ago

The ”target” field in ”URLLaunch” in the config doesn’t actually work. I tried changing its value to “_blank” which means that it would open every link in a new tab but it actually doesn’t….

mureev commented 5 months ago

+1, I've noticed the same.

excalith commented 5 months ago

Sorry for the delay guys, having some health related stuff lately. After a huge refactoring, I believe I forgot to update the filtered links. The urls that clicked was intended to launch within the same window, but I realise this is confusing so changed it as well.

Here is the upcoming hotfix:

Clicking links will read target from settings instead of opening within same page
Fixed an issue filtered links does not read target from settings if only 1 filtered option is available

Will do some tests and release it as soon as possible.

mureev commented 5 months ago

Thanks a ton and take care. I hope you get better soon!

excalith commented 5 months ago

Hey @mureev, thanks for your kind words. Hopefully will get better soon!

Just released the fix with and deployed to vercel and registries. You can check the online version for working demo. Here is the release notes for the changes.

Cheers to you both and thanks for the report!