search

excamera / alfalfa

Purely functional video codec, used for ExCamera and Salsify
GNU General Public License v2.0
1.2k stars 112 forks source link

alfalfa-import utility created. #30

Closed sadjad closed 8 years ago

sadjad commented 8 years ago

There are some necessary changes that Deepak and I going to make, and I'm going to close this pull request. I will make a new pull request as soon as they're done (hopefully very soon!).

keithw commented 8 years ago

Ok! Also: let's not commit auto-generated protobuf files into the repository. Instead, they should be built as part of the build system. (See https://github.com/ravinet/mahimahi/tree/master/src/protobufs for how to do this.)

Otherwise we have a problem where our code will stop compiling once the user upgrades their version of protobuf...

sadjad commented 8 years ago

They're not in the repository, I've put them in the .gitignore. I think I used the exact same approach as Mahimahi. https://github.com/sadjad/alfalfa/blob/e035117d25e83c1409532985b16f2a9dcf27d67e/.gitignore

keithw commented 8 years ago

Whoops, apparently I read too fast!

sadjad commented 8 years ago

We changed the way we were storing databases to make them ready to create alfalfa-combine and other necessary commands. We also squashed all the commits together.