search

excamera / alfalfa

Purely functional video codec, used for ExCamera and Salsify
GNU General Public License v2.0
1.2k stars 112 forks source link

Alfalfa server refactor #59

Closed deepakn94 closed 8 years ago

deepakn94 commented 8 years ago

@keithw

keithw commented 8 years ago

Naively this seems way more complicated than I was guessing -- do we really need all these C++ objects (with Optionals) and then logic to serialize/deserialize them to and from the corresponding protobufs?

Could you give a shot at trying to do this by just having AlfalfaVideoClient directly construct a request protobuf, and AlfalfaVideoServer directly interprets the protobuf into a function call and then replies with the corresponding protobuf? Seems like that would be a lot simpler.

deepakn94 commented 8 years ago

@keithw: Tried to clean up. Let me know if anything doesn't look ok to you!