Fix tests: Don't rely on equal binary data

excellenteasy / grunt-image-resize

Unmaintained. If you'd like to take this over please let us know. Resizing images made easy - thanks to imagemagick.

MIT License

57 stars 46 forks source link

Fix tests: Don't rely on equal binary data #1

Closed davidpfahler closed 11 years ago

davidpfahler commented 11 years ago

Tests relied on the files being exactly the same - on a binary level. That made them fail on Travis CI, because I can't make sure that the exact same version of imagemagick is installed on travis and my machine. Now tests should just compare the width of the generated images.

normanrz commented 11 years ago

I guess it would be cool to use the compare function from gm (http://aheckmann.github.io/gm/docs.html#compare) for that. Unfortunately it is currently only supported for GraphicsMagick (see https://github.com/aheckmann/gm/issues/230).

normanrz commented 10 years ago

https://github.com/aheckmann/gm/issues/230 is resolved now.