search

excellenteasy / grunt-image-resize

Unmaintained. If you'd like to take this over please let us know. Resizing images made easy - thanks to imagemagick.
MIT License
57 stars 46 forks source link

Default width generates 1x1 image #28

Closed sophietk closed 8 years ago

sophietk commented 9 years ago

Hi,

The plugin allowed specifying only width -or height- to maintain the aspect ratio of the image. Now, that causes the generated image size to be 1x1.

Since the commit aheckmann/gm@781fb82 changes the gm resize implementation, a 0-value is considered as a valid width/height. The grunt-image-resize should not provide '0' as default value anymore. Instead '' (empty string) should do the job.

pattiereaves commented 9 years ago

@sophietk THANK YOU THANK YOU THANK YOU. I had this problem for weeks and had no idea what the issue was. You need to pass an empty string for height, too.

nadnoslen commented 8 years ago

Yes thank you @sophietk. This issue got me a month ago and had me vexed. I think we all need to find a new library considering this one is no longer being maintained.

thebiltheory commented 7 years ago

@sophietk Sank U !