search

excellenteasy / grunt-image-resize

Unmaintained. If you'd like to take this over please let us know. Resizing images made easy - thanks to imagemagick.
MIT License
57 stars 46 forks source link

Update peerDependencies to support Grunt 1.0 #30

Closed grunt-updater2 closed 8 years ago

grunt-updater2 commented 8 years ago

Update peerDependencies to support Grunt 1.0

Hello,

This is an automated issue request to update the peerDependencies for your Grunt plugin. We ask you to merge this and publish a new release on npm to get your plugin working in Grunt 1.0!

Read more here: http://gruntjs.com/blog/2016-02-11-grunt-1.0.0-rc1-released#peer-dependencies Also on Twitter: https://twitter.com/gruntjs/status/700819604155707392

If you have any questions or you no longer have time to maintain this plugin, then please let us know in this thread.

Thanks for creating and working on this plugin!

(P.S. Close this PR if it is a mistake, sorry)

fboes commented 8 years ago

Is there a way to help with testing this feature and getting this merged? I am very much in love with this plugin, as it helps on building favicons and article images over at https://github.com/fboes/broilerplate

davidpfahler commented 8 years ago

@fboes That's very nice to hear. If you could just use this PR and play around with it and confirm it works, I'm fine with merging it.

fboes commented 8 years ago

I'm always happy to assist. 😁 I just ran my Broilerplate-Gruntfile.js with the proposed alterations to grunt-image-resize. This is the result:

$ grunt image_resize
Running "image_resize:fav32" (image_resize) task
>> Image htdocs/images/logo.png resized to htdocs/favicon.ico

Running "image_resize:fav96" (image_resize) task
>> Image htdocs/images/logo.png resized to htdocs/favicon-96x96.png

Running "image_resize:fav152" (image_resize) task
>> Image htdocs/images/logo.png resized to htdocs/apple-touch-icon-precomposed.png

Running "image_resize:fav196" (image_resize) task
>> Image htdocs/images/logo.png resized to htdocs/favicon-196x196.png

Running "image_resize:tile128" (image_resize) task
>> Image htdocs/images/logo.png resized to htdocs/images/tile-128x128.png

Running "image_resize:tile270" (image_resize) task
>> Image htdocs/images/logo.png resized to htdocs/images/tile-270x270.png

Running "image_resize:tilewide" (image_resize) task
>> Image htdocs/images/logo.png resized to htdocs/images/tile-558x270.png

Running "image_resize:tile558" (image_resize) task
>> Image htdocs/images/logo.png resized to htdocs/images/tile-558x558.png

Running "image_resize:article_images" (image_resize) task
>> Image htdocs/images/originals/article.jpg resized to htdocs/images/articles-640/

Running "image_resize:article_images2" (image_resize) task
>> Image htdocs/images/originals/article.jpg resized to htdocs/images/articles-1280/

Done.

Also running npm outdated and npm update does not yield any warnings (as it did before this patch). And the dependencies of grunt-image-resize are still fine with Grunt 1.0.0 as far as I can tell. So for me this single line of change is working just fine. 👍