excelwebzone / EWZRecaptchaBundle

This bundle provides easy reCAPTCHA form field for Symfony.
MIT License
396 stars 160 forks source link

Add support for Symfony 5 and Phpunit 8 #235

Closed Sander-Toonen closed 3 years ago

Sander-Toonen commented 4 years ago

Symfony 5 got released today. Let's make this bundle compatible with that! I believe the constraints can be updated without breaking anything, also updated the README a bit to reflect the new config path that is used since Symfony 4.

remmel commented 4 years ago

@excelwebzone Hi, can you please accept that PR?

excelwebzone commented 4 years ago

build failed.. make sure to fix it before I merge it. Thanks.

remmel commented 4 years ago

Finally that PR is partly useless as Symfony 5 is now handled : https://github.com/excelwebzone/EWZRecaptchaBundle/commit/1e87dff482391892c47b858e41e4150913785927 (but not Phpunit 8)

excelwebzone commented 4 years ago

@Sander-Toonen Please fix the unit testing before I can merge the code. Thanks.