search

excelwebzone / EWZRecaptchaBundle

This bundle provides easy reCAPTCHA form field for Symfony.
MIT License
395 stars 160 forks source link

Php8 support #268

Closed VincentLanglet closed 3 years ago

VincentLanglet commented 3 years ago

Hi @excelwebzone, is it possible to support php 8 ?

I saw this PR working on it https://github.com/excelwebzone/EWZRecaptchaBundle/pull/267

excelwebzone commented 3 years ago

Unfortunately, upgrading to PHP8 will required large code change. The PR you referring too, can' tbe merged - If @pbories will fix it I will merge change.

VincentLanglet commented 3 years ago

Then the issue should stay open until the php8 support is added.

What do you mean large code change ? Seems like @pbories was needed an answer about what to do this the tests. Php8 is supported by PhpUnit >= 8 which require to add return type : void to setUp method ; doing this change need to restrict the php version of the ci to 7.1+. Do you agree with this ?

excelwebzone commented 3 years ago

I guess so..