exceptionless / Exceptionless.JavaScript

Exceptionless JavaScript client
http://exceptionless.com
Apache License 2.0
59 stars 24 forks source link

fix construction of ExceptionlessClient #43

Closed csantero closed 8 years ago

csantero commented 8 years ago

According to the readme, you should be able to instantiate an ExceptionlessClient like so:

var client = new exceptionless.ExceptionlessClient('API_KEY_HERE');
// or with an api key and server url
var client = new exceptionless.ExceptionlessClient('API_KEY_HERE', 'http://localhost:50000');
// or with a configuration object
var client = new exceptionless.ExceptionlessClient({
  apiKey: 'API_KEY_HERE',
  serverUrl: 'http://localhost:50000',
  submissionBatchSize: 100
});

As far as I can tell, these constructor arguments don't actually work as-is, due to a flipped equality comparison in the constructor.

CLAassistant commented 8 years ago

CLA assistant check
All committers have accepted the CLA.

niemyjski commented 8 years ago

Awesome thank you! It looks like the lint task failed, could you please take a look into this.

csantero commented 8 years ago

@niemyjski Sorry about that... should be good now.

niemyjski commented 8 years ago

Thanks!

niemyjski commented 8 years ago

Do you need a release for this change?

csantero commented 8 years ago

@niemyjski Nah... it's easy enough to work around this bug by setting client.config.apiKey = ... after constructing.