search

exceptionless / Exceptionless.JavaScript

Exceptionless JavaScript client
http://exceptionless.com
Apache License 2.0
59 stars 24 forks source link

Fixed "TypeError: undefined is not an object (evaluating '$log.error.logs.push')" error in angular integration #60

Closed mkalpana closed 8 years ago

mkalpana commented 8 years ago

This PR fixes issues related to

"TypeError: undefined is not an object (evaluating '$log.error.logs.push') in ./bower_components/angular-mocks/angular-mocks.js"

error when exceptionless angular integration library is used in a project with unit testing.

angular-mocks library expects a logs property on $log.info, $log.warn, $log,error, $log.log and $log.debug objects and is used when $log.error()... methods are called.

https://github.com/angular/angular.js/blob/master/src/ngMock/angular-mocks.js#L332-L388

https://github.com/angular/angular.js/blob/master/src/ngMock/angular-mocks.js#L300-L303

Since this is not defined on the $log exceptionless decorator, errors occur in unit tests using $log service.

CLAassistant commented 8 years ago

CLA assistant check
All committers have signed the CLA.

niemyjski commented 8 years ago

Thanks! We really appreciate it!

niemyjski commented 8 years ago

We have some testing to do and then we want to push out a new release.

niemyjski commented 8 years ago

This has been deployed (https://github.com/exceptionless/Exceptionless.JavaScript/releases/tag/v1.4.2) Thank you for your contributions!