search

exceptionless / Exceptionless.Net

Exceptionless clients for the .NET platform
https://exceptionless.com
Other
555 stars 142 forks source link

NLog Target skip allocation of List when no tags #172

Closed snakefoot closed 6 years ago

snakefoot commented 6 years ago

https://github.com/exceptionless/Exceptionless.Net/blob/0925d4742e28325f17a31290a0fd68e323e93734/src/Platforms/Exceptionless.NLog/ExceptionlessClientExtensions.cs#L52

No need to allocate List<string>-object and inserting into properties-Dictionary, when just wanting to check if any Tags.

ejsmith commented 6 years ago

Agreed with this change as well.

snakefoot commented 6 years ago

@ejsmith Just doing code-review. Not using ExceptionLess

snakefoot commented 6 years ago

Maybe it could be fixed by extending the suggested solution in #173 (Check for propertyKey = "Tags")

niemyjski commented 6 years ago

Fixed in https://github.com/exceptionless/Exceptionless.Net/commit/585057e09a9d357c906a030eb8c906d29e12b384 Thanks for reporting these issues! It's greatly appreciated