exceptionless / Exceptionless.Net

Exceptionless clients for the .NET platform
https://exceptionless.com
Other
554 stars 142 forks source link

Add Exceptionless.Windows&Wpf for dotnet core 3.0 rc #216

Closed rwecho closed 4 years ago

rwecho commented 4 years ago

Copy windows&wpf project to generate new dotnet core 3.0 version.

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

niemyjski commented 4 years ago

@rwecho awesome! Thanks for the pr :). Was there any specific changes needed for core support? I'm wondering what it would take to use the same NuGet package/existing projects as I know we can upgrade the existing via csproj and do multi targeting. I'm guessing you tried this? What issues did you run into? Thanks again

rwecho commented 4 years ago

hi @niemyjski Thanks for your reply. I was afraid of impating the users using the fx version. The question I met when modified.

  1. '/Images/ErrorFeedback.png' can found in resource. fix with '/Exceptionless.Wpf.Core;component/Images/ErrorFeedback.png' I found no reason.
  2. 'CrashReportForm.resx' can found in Exceptionless.Windows. fix with add something in the csproj
    <ItemGroup>
    <EmbeddedResource Update="Dialogs\CrashReportForm.resx">
      <SubType>Designer</SubType>
      <DependentUpon>CrashReportForm.cs</DependentUpon>
    </EmbeddedResource>
    </ItemGroup>

And I add new commits : remove dotnet core version && replace windows with multi targeting.

niemyjski commented 4 years ago

Thanks for your help. I think multi targeting is the best approach. I'll help test this as well :).

niemyjski commented 4 years ago

I'm just checking in to see how things were going. Did you have any luck merging these?

niemyjski commented 4 years ago

@rwecho is there anything I can do to help with this pr?

niemyjski commented 4 years ago

@rwecho is there anything I can do to help with this pr?

rwecho commented 4 years ago

@niemyjski Sorry for late reply . I am not familiar with appveyor/cla. It warns me build failed and let me sign the license. I don't know what to do.

I thought you will resolve it . But sorry for ignoring this again. image

Could you tell me what I should do next ? Thanks.

niemyjski commented 4 years ago

Thanks for the PR! I merged it into a branch so I can continue testing it and update the build if required.