search

exceptionless / Exceptionless.Net

Exceptionless clients for the .NET platform
https://exceptionless.com
Other
554 stars 142 forks source link

Got wrong MachineName when using Exceptionless client v4.4.0 #233

Closed witskeeper closed 4 years ago

witskeeper commented 4 years ago

Got wrong MachineName when using Exceptionless client v4.4.0 with ASP.NET Core 3.1.x

Exceptionless v4.3.x works well.

niemyjski commented 4 years ago

What is the difference between process machine name and the environment machine name for you? Also, I'm wondering if we should be falling back to environment machine name if the process.MachineName is empty? (would it ever be empty). Looks like Process.MachineName will return the computer name where the process is running on . https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.process.machinename?view=netcore-3.1 Makes me think we should be using the process instead of the actual machine name.

witskeeper commented 4 years ago

this bug came from v4.4.0 and you can see the changes of code. old version use process.MachineName when #elif !PORTABLE && !NETSTANDARD1_2

So , we can just use Environment.MachineName now.

DE422C88-80A7-4173-94B9-169D7000CCAD

niemyjski commented 4 years ago

Thanks for the PR!

witskeeper commented 4 years ago

when will the new version be released ？ @niemyjski

niemyjski commented 4 years ago

We like to try and get a few changes out in each release, can you use a nightly build for now?

yuefengkai commented 4 years ago

If this issues is resolved, please notify me, thank you @niemyjski

niemyjski commented 4 years ago

this issue is resolved and merged in, you can find the nuget packages on our nightly ci feed: https://f.feedz.io/exceptionless/exceptionless/nuget/index.json

niemyjski commented 4 years ago

A new release is building right now: https://github.com/exceptionless/Exceptionless.Net/releases/tag/v4.4.1