search

exceptionless / Exceptionless.Net

Exceptionless clients for the .NET platform
https://exceptionless.com
Other
554 stars 142 forks source link

The FolderObjectStorage class SaveObject<T>method has a issues #246

Closed d18zj closed 3 years ago

d18zj commented 3 years ago

When log level is changed from DEBUG to INFO, The client-side server-settings.json file will be incorrect. ``

{"@@UserAgentBotPatterns":"bot,crawler,spider,aolbuild,teoma,yahoo","@@log:*":"debug"} ``

After the update, there is an additional } sign at the end

{"@@UserAgentBotPatterns":"*bot*,*crawler*,*spider*,*aolbuild*,*teoma*,*yahoo*","@@log:*":"info"}}

should modify FolderObjectStorage.cs like this: image

niemyjski commented 3 years ago

Thanks for this report and nice find! I wonder why we did OpenWrite there. Is there any chance you could create a test and submit this change in a pr?