search

exceptionless / Exceptionless.Net

Exceptionless clients for the .NET platform
https://exceptionless.com
Other
551 stars 142 forks source link

Add Windows environment info collector to the WPF platform #291

Closed mgnslndh closed 1 year ago

mgnslndh commented 1 year ago

Fixes #290 by add source link to ExceptionslessWindowsEnvironmentInfoCollector in the WPF platform project and registering that services to the dependency resolver.

          You should only need to use the Wpf client, code is shared between the clients. I'm trying to think if there is any reason we shouldn't be capturing that environment info in wpf. I can't think of any reason not to.. Would you mind submitting a pr to add a source link to that file in the wpf project and then adding a line to `client.Configuration.Resolver.Register<IEnvironmentInfoCollector, ExceptionlessWindowsEnvironmentInfoCollector>();` in register.

Originally posted by @niemyjski in https://github.com/exceptionless/Exceptionless.Net/issues/290#issuecomment-1398800297

mgnslndh commented 1 year ago

Not sure why the tests fail because they green on my machine :)

niemyjski commented 1 year ago

@mgnslndh can you sign the cla, looks like a flakey test we need to look into.

mgnslndh commented 1 year ago

Cloudflare is reporting the clahub as down. Not sure if it is affected by the service outage at Microsoft. https://www.clahub.com/agreements/exceptionless/Exceptionless

I will sign as soon as I can when the site is up and running.

mgnslndh commented 1 year ago

@niemyjski I've signed the CLA. The link was wrong but I've submitted another PR fixing that.

niemyjski commented 1 year ago

Thanks for the PR!