time_separator option - Githubissues

excid3 / combined_time_select

A Rails time_select like Google Calendar with combined hour and minute time_select

MIT License

61 stars 22 forks source link

time_separator option #5

Open kakoni opened 11 years ago

kakoni commented 11 years ago

Perhaps you should mention the importance of time_seperator option. Otherwise there is this extra colon outside the select field (wow, did I spent some time finding this;)

excid3 commented 11 years ago

Ha! I noticed that a while back but totally forgot about it. Good idea.

I almost feel like making a new time selector method that automatically sets some of these options for you. Would that make more sense?

kakoni commented 11 years ago

Well since you're thinking about it;)-> Could you also make am/pm vs 24hour option? And yes, setting time_seperator automatically/completely hiding it makes sense