search

excid3 / jumpstart

Easily jumpstart a new Rails application with a bunch of great features by default
http://jumpstartrails.com
MIT License
1.2k stars 316 forks source link

Uninitialized constant HomeController on Rails 7.0.1 fresh install #169

Closed thomasgallagher closed 2 years ago

thomasgallagher commented 2 years ago

Hi Chris,

Not sure if you support 7.0.1 yet but I get an exception on fresh install

ruby 3.0.3p157 (2021-11-24 revision 3fb7d2cadc) [x86_64-darwin21] Rails 7.0.1 output.log

Did I miss something?

Many thanks, Tom

excid3 commented 2 years ago

Did it not copy the home_controller or views over?

thomasgallagher commented 2 years ago

Doesn't look like it, although the root route does exist.

Screenshot 2022-01-14 at 11 41 31

excid3 commented 2 years ago

On this line, we copy the whole app directory over, so it seems like that didn't run for you or something. https://github.com/excid3/jumpstart/blob/master/template.rb#L134

Have you tried generating a new app more than once to see if it's repeatable?

thomasgallagher commented 2 years ago

Hmm, yeah I see that line so that is strange.

The problem is replicable each time I generate a new app. Tried ruby 2.7.2 and Rails 6.1 both with the remote script and with the cloned repository - same result.

The test also fails: test.log

I am on MacOS 12.1 (Intel) if that makes any difference (filesystem perms perhaps?)?

T

excid3 commented 2 years ago

I've been testing with Ruby 3 and Rails 7, but I wouldn't expect those to affect it.

What's interesting is it appears to have stopped after the add_javascript line and stopped before adding announcements. I'll have to see if I can replicate this.

thomasgallagher commented 2 years ago

👍

Let me know if I can help in any way...

excid3 commented 2 years ago

Just ran this a bunch of times tonight with no issues. Going to close this, but feel free to reopen if you can figure out a way to reproduce the issue. 👍

thomasgallagher commented 2 years ago

Hey Chris,

Figured it out, I didn't have yarn installed. I would have added it to the README in a PR, but it's already there. Sorry for wasting your time.

T

excid3 commented 2 years ago

Ah that would do it!