excid3 / jumpstart

Easily jumpstart a new Rails application with a bunch of great features by default
http://jumpstartrails.com
MIT License
1.2k stars 316 forks source link

Use `setup-rails` for CI? #185

Closed andyw8 closed 1 year ago

andyw8 commented 2 years ago

:wave:

I recently published setup-rails, a reusable GitHub CI workflow:

https://www.andywaite.com/2022/04/15/reusable-github-actions-rails-workflow.html

I'm hoping this would be a useful addition to Jumpstart. Here's an example of it in use:

http://github.com/andyw8/jumpstart-setup-rails

(I had to make a small adjustment to the fixtures).

I understand that not everyone wants to use GitHub Actions, but the file would have no effect if running on another CI platforms.

excid3 commented 1 year ago

This is great @andyw8. Meant to get to this way sooner, but better late than never!

excid3 commented 1 year ago

RE: the fixtures changes, should we override the fixtures file? Right now we're just using the fixtures file that Devise generates.

Probably should have done this before merging, but YOLO!

andyw8 commented 1 year ago

@excid3 would you be interested in using this on Jumpstart Pro?