Closed eclectic-coding closed 1 year ago
We are not checking if the user overrides the default system Rails version What happens when they do that? Should still work right?
If their default system Rails version is 7
, the check would assume it is a Rails 7 install.
If the user overrides, as mentioned above, and the default system Rails version is 7
, it will fail as before.
If we would want to check for this edge case, we would need to figure out either how to read the version prefix in the cli args, or read from the already created Gemfile
, which happens before the template.rb
is accessed.
@excid3 I have addressed this edge case
Also, I removed the version check in the add_users
method since we are now assuming Rails 7.
@excid3 This removes Rails 6 installs #198 :
rails_7_or_newer?
sooner so we can exit out before the install gets too farOne edge case We are not checking if the user overrides the default system Rails version:
rails _6.1.7_ new appname ...
.