search

excid3 / jumpstart

Easily jumpstart a new Rails application with a bunch of great features by default
http://jumpstartrails.com
MIT License
1.2k stars 316 forks source link

Omit `config.action_mailer.default_url_options` in next release of Rails #211

Closed stevepolitodesign closed 8 months ago

stevepolitodesign commented 9 months ago

Once https://github.com/rails/rails/pull/51191 is in the next Rails release, we can omit the following line:

https://github.com/excid3/jumpstart/blob/edfcc4bba8546b99e60eb0feccc78cff382caa6d/template.rb#L79

stevepolitodesign commented 9 months ago

@excid3 feel free to close this or move this to a backlog. I just wanted to bring it to your attention 👍

excid3 commented 9 months ago

Great improvement @stevepolitodesign 👍

excid3 commented 8 months ago

Going to close this for now since we'll still need this line for older Rails version unless we drop support for them at some point.