excid3 / madmin

A robust Admin Interface for Ruby on Rails apps
https://github.com/excid3/madmin
MIT License
546 stars 62 forks source link

Remove TailwindCSS CDN and ship as tailwindcss-rails #214

Closed LEstradioto closed 3 weeks ago

LEstradioto commented 4 weeks ago

This PR addresses the request to remove the TailwindCSS CDN and include our own stylesheet, as @excid3 said in issue #198

I'd like to drop the TailwindCSS CDN and just ship our own stylesheet soon if anyone wants to PR that. We could also probably do the same for the JavaScript.

CDNs were just the easiest to figure out while Rails was in the jsbundling /cssbundling / propshaft / importmap mess. I think things have settled out enough that we can ship our own assets and importmaps. I need to look into how MissionControl handles assets and we can cut a new release with those changes.

Changes

Note: Sprockets remains, but Tailwind file is ignored

Questions

I'm not certain if this PR fully meets your expectations.

  1. Should we proceed with similar changes for JavaScript assets?
  2. Are we aiming for importmaps with external links, bundled assets, or a mix?
  3. Is the referenced MissionControl the mission_control-jobs gem? If so, should we follow their approach of using Gemfiles for Stimulus, Turbo, and other packages? like their importmap and gemspec

I can continue with JavaScript assets once we clarify the preferred approach. Please let me know if any adjustments are needed for this PR or if you'd like me to proceed with further changes.

LEstradioto commented 3 weeks ago

Just saw test failing will check later!

excid3 commented 3 weeks ago

I think we're going to just drop TailwindCSS entirely and use some plain CSS for the next major release.

LEstradioto commented 3 weeks ago

Closing following instructions above