excid3 / noticed

Notifications for Ruby on Rails applications
MIT License
2.4k stars 169 forks source link

Include routes and `Noticed::Translation` in `Noticed::Ephemeral` #485

Closed ghiculescu closed 2 weeks ago

ghiculescu commented 2 weeks ago

Ooops, I should have included this in https://github.com/excid3/noticed/pull/484, sorry.

Matches https://github.com/excid3/noticed/blob/505e6c9fc0cc58eb27714ddd449c819490f57368/app/models/noticed/event.rb#L5

excid3 commented 2 weeks ago

Ah yep, missed that too.

I also just realized, I don't think we include the url_helpers or translation in Event::Notification which we probably should do too.

Nevermind, we're already including those in Noticed::Notification