Currently, If logo key in the company hash is set to empty string then we are trying to open a file at "", which is causing the system to crash with an error.
Proposed fix:
Do not try to open a file if the logo (path) provided is an empty string.
This Fix updates the logic around reading the logo path from company hash to avoid trying to open a file if the path provided is an empty string
Use case:
let's say this gem is consumed in an application which deals with multiple company objects and some company object might not have a logo and some might. In this case, if we the company hash is built by setting the logo to an empty string (for a company that might not have logo or if it is deleted for some reason), then it should just ignore it rather than trying to open the non-existing file.
excid3
commented
6 years ago
Description
Currently, If
logokey in thecompanyhash is set to empty string then we are trying to open a file at"", which is causing the system to crash with an error.Proposed fix:
Do not try to open a file if the logo (path) provided is an empty string.
This Fix updates the logic around reading the logo path from company hash to avoid trying to open a file if the path provided is an empty string
Use case:
let's say this gem is consumed in an application which deals with multiple company objects and some company object might not have a logo and some might. In this case, if we the
companyhash is built by setting the logo to an empty string (for a company that might not have logo or if it is deleted for some reason), then it should just ignore it rather than trying to open the non-existing file.