search

excid3 / simple_calendar

A wonderfully simple calendar gem for Rails
http://excid3.github.io/simple_calendar
MIT License
1.58k stars 268 forks source link

Replace span element with semantic 'Time' element #289

Closed elhalvers closed 2 years ago

elhalvers commented 2 years ago

Improve Accessibility

In an effort to maintain good semantic HTML for accessibility, we replaced the <span> element with the new <time> element in the _month_calendar.html.erb partial using a dynamic datetime attribute.

Reference: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/time

Co-conspirators: @kingrowen, @galtdea, @cjilbert504

excid3 commented 2 years ago

Very good improvement! I always forget to use the time element. 👍

elhalvers commented 2 years ago

Yay!

Thanks!

: )

Eric

On Sep 26, 2022, at 09:14, Chris Oliver @.***> wrote:

 Merged #289 into master.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

elhalvers commented 2 years ago

Awesome! Collin's good idea. I got to drive and write the PR with input from everyone! 🙂

GALTdea commented 2 years ago

You did a great Job, Eric!

devcamke commented 2 years ago

awesome!

elhalvers commented 2 years ago

Thank you Gustavo! Thank you for the great contributions!

: )

On Mon, Sep 26, 2022 at 11:19 AM Gustavo Valenzuela < @.***> wrote:

You did a great Job, Eric!

— Reply to this email directly, view it on GitHub https://github.com/excid3/simple_calendar/pull/289#issuecomment-1258431227, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR3VCDP523GDREQQC2PBPB3WAHSKBANCNFSM6AAAAAAQU2QB6I . You are receiving this because you authored the thread.Message ID: @.***>