search

excid3 / tailwindcss-stimulus-components

A set of StimulusJS components for TailwindCSS apps similar to Bootstrap JS components.
https://excid3.github.io/tailwindcss-stimulus-components/
MIT License
1.36k stars 137 forks source link

Update web-test-runner concurrency to 1 #226

Closed pkayokay closed 6 months ago

pkayokay commented 6 months ago

This may help reduce the failures we're seeing in CI and local. I actually got pretty consistent results of passing tests locally by reducing the concurrency option to 1.

Similar issue found here

excid3 commented 6 months ago

Excellent! Thanks!

pkayokay commented 5 months ago

@excid3 I found out we could alternatively update the timeout as well in the config. If the solution here is inconsistent we can also up the timeout time. Adding this as a comment here in case we need it in the future.

{
  concurrency: 1,
  files: "test/**/*_test.js",
  nodeResolve: true,
  filterBrowserLogs,
  mimeTypes: {},
  plugins: [],
  testFramework: {
    config: {
      timeout: '10000',
    },
  },
}
excid3 commented 5 months ago

Cool, it seems pretty stable now with concurrency of 1 and we only have a few tests so it's fast enough.

I don't really understand the flakiness having more concurrency though. 🤷‍♂️

excid3 commented 5 months ago

One thing I did notice yesterday, one test was consistently failing because we initialize the fixture before Stimulus in the test. Swapping the order to initialize the Stimulus component and then load the fixture made it reliable. Maybe that was the source of it?